chore(deps): update dependency maven-wrapper to v3.3.4#99
Conversation
🤖 Augment PR SummarySummary: Updates the Apache Maven Wrapper configuration and bootstrap scripts so the build uses a newer wrapper JAR and refreshed launcher logic. Changes:
Technical Notes: The Maven distribution ( 🤖 Was this summary useful? React with 👍 or 👎 |
| # under the License. | ||
| distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.6.1/apache-maven-3.6.1-bin.zip | ||
| wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar | ||
| wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar |
There was a problem hiding this comment.
.mvn/wrapper/maven-wrapper.properties:18 pins wrapperUrl to maven-wrapper-3.2.0.jar, but this PR’s title/description indicate an upgrade to 3.3.4. This mismatch can be confusing and may miss fixes expected from the described version bump.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| [ -n "$JAVA_HOME" ] && | ||
| JAVA_HOME="`(cd "$JAVA_HOME"; pwd)`" | ||
| [ -n "$JAVA_HOME" ] && [ -d "$JAVA_HOME" ] && | ||
| JAVA_HOME="$(cd "$JAVA_HOME" || (echo "cannot cd into $JAVA_HOME."; exit 1); pwd)" |
There was a problem hiding this comment.
mvnw:89 uses cd "$JAVA_HOME" || (echo ...; exit 1); pwd, but the exit runs in a subshell so pwd will still execute on failure, potentially setting JAVA_HOME to the current directory. That could lead to running with an incorrect JAVA_HOME rather than failing fast.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| # end of workaround | ||
| done | ||
| echo "${basedir}" | ||
| printf '%s' "$(cd "$basedir" || exit 1; pwd)" |
There was a problem hiding this comment.
mvnw:157 does printf '%s' "$(cd "$basedir" ...; pwd)"; if .mvn isn’t found and basedir stays empty, cd "" resolves to $HOME and returns a non-empty path. That would bypass the later -z "$BASE_DIR" guard and make failures harder to diagnose.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| # If specified, validate the SHA-256 sum of the Maven wrapper jar file | ||
| wrapperSha256Sum="" | ||
| while IFS="=" read -r key value; do | ||
| case "$key" in (wrapperSha256Sum) wrapperSha256Sum=$value; break ;; |
There was a problem hiding this comment.
mvnw:257 reads wrapperSha256Sum without stripping a trailing \r, while the earlier wrapperUrl parsing explicitly removes \r. On Windows/CRLF checkouts this can cause checksum validation to fail even with a correct hash.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
31c0b1c to
ebb2fcb
Compare
|
This PR contains the following updates:
3.1.0→3.3.4Release Notes
apache/maven-wrapper (maven-wrapper)
v3.3.4: 3.3.4Compare Source
🐛 Bug Fixes
👻 Maintenance
v3.3.3: 3.3.3Compare Source
💥 Breaking changes
🚀 New features and improvements
🐛 Bug Fixes
📝 Documentation updates
👻 Maintenance
📦 Dependency updates
v3.3.2: 3.3.2Compare Source
Release Notes - Maven Wrapper - Version 3.3.2
Bug
Improvement
Task
What's Changed
New Contributors
Full Changelog: apache/maven-wrapper@maven-wrapper-3.3.1...maven-wrapper-3.3.2
v3.3.1: 3.3.1Compare Source
Release Notes - Maven Wrapper - Version 3.3.1
Improvement
What's Changed
Full Changelog: apache/maven-wrapper@maven-wrapper-3.3.0...maven-wrapper-3.3.1
v3.3.0: 3.3.0Compare Source
Release Notes - Maven Wrapper - Version 3.3.0
Bug
Improvement
Task
Dependency upgrade
What's Changed
New Contributors
Full Changelog: apache/maven-wrapper@maven-wrapper-3.2.0...maven-wrapper-3.3.0
v3.2.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.